Mailing-List: contact php-cvs-help@lists.php.net; run by ezmlm
Precedence: bulk
Reply-to: marcus.boerger@post.rwth-aachen.de
Message-Id: <5.1.0.14.2.20021028193555.01d47c20@mailbox.rwth-aachen.de>
Date: Mon, 28 Oct 2002 19:36:10 +0100
To: Melvyn Sopacua <msopacua@idg.nl>
From: marcus.boerger@t-online.de (Marcus =?iso-8859-1?Q?B=F6rger?=)
Cc: php-cvs@lists.php.net
In-Reply-To: <5.1.0.14.2.20021028192151.039729e0@yoshimo.webtechs.idg.nl
 >
References: <5.1.0.14.2.20021028190015.01d4d650@mailbox.rwth-aachen.de>
 <5.1.0.14.2.20021028183051.03c18958@yoshimo.webtechs.idg.nl>
 <cvshelly1035825322@cvsserver>
Mime-Version: 1.0
Content-Type: multipart/alternative;
	boundary="=====================_71195359==_.ALT"
Subject: Re: [PHP-CVS] cvs: php4 /ext/iconv/tests

--=====================_71195359==_.ALT
Content-Type: text/plain; charset="iso-8859-1"; format=flowed
Content-Transfer-Encoding: quoted-printable

Then what about:

cvs -z3 -q diff skipif.inc test.inc (in directory=20
S:\php4-HEAD\ext\iconv\tests\)
Index: skipif.inc
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /repository/php4/ext/iconv/tests/skipif.inc,v
retrieving revision 1.2
diff -u -r1.2 skipif.inc
--- skipif.inc  28 Oct 2002 17:15:21 -0000      1.2
+++ skipif.inc  28 Oct 2002 18:35:25 -0000
@@ -1,10 +1,11 @@
  <?php
  // This script prints "skip" if condition does not meet.

-if (!extension_loaded("iconv") && ini_get("enable_dl")) {
-  $dlext =3D (substr(PHP_OS, 0, 3) =3D=3D "WIN") ? ".dll" : ".so";
-  @dl("iconv$dlext");
-}
+// Do not dl load extension
+//if (!extension_loaded("iconv") && ini_get("enable_dl")) {
+//  $dlext =3D (substr(PHP_OS, 0, 3) =3D=3D "WIN") ? ".dll" : ".so";
+//  @dl("iconv$dlext");
+//}
  if (!extension_loaded("iconv")) {
      die("skip iconv extension not available\n");
  }
Index: test.inc
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /repository/php4/ext/iconv/tests/test.inc,v
retrieving revision 1.1
diff -u -r1.1 test.inc
--- test.inc    28 Oct 2002 17:15:21 -0000      1.1
+++ test.inc    28 Oct 2002 18:35:25 -0000
@@ -1,8 +1,7 @@
  <?php
-// This script prints "skip" if condition does not meet.
-
-if (!extension_loaded("iconv") && ini_get("enable_dl")) {
-  $dlext =3D (substr(PHP_OS, 0, 3) =3D=3D "WIN") ? ".dll" : ".so";
-  @dl("iconv$dlext");
-}
+// Do not dl load extension
+//if (!extension_loaded("iconv") && ini_get("enable_dl")) {
+//  $dlext =3D (substr(PHP_OS, 0, 3) =3D=3D "WIN") ? ".dll" : ".so";
+//  @dl("iconv$dlext");
+//}
  ?>

At 19:30 28.10.2002, Melvyn Sopacua wrote:
>At 19:01 28-10-2002, Marcus B=F6rger wrote:
>
>>At 18:33 28.10.2002, Melvyn Sopacua wrote:
>>>At 18:15 28-10-2002, Marcus B=F6rger wrote:
>>>
>>>>   Log:
>>>>   fix this tests
>>>>   -they did not dl load module in test....
>>>
>>>Yes, exactly as they shouldn't.
>>>
>>>It's been discussed. Why did you revert that?
>>>
>>>The main reason - to repeat it:
>>>./configure --prefix=3D/previous/install
>>>
>>>dl('foo.so')    =3D> foo.so version is previous install, not current!
>>
>>I did so because skipif.inc did so. Maybe we remove that code
>>from both skipif.inc and test.inc now. Feel free to do that.
>
>Ok, then that was a left over.
>
>IMHO we should do a complete overhaul of */tests/* and remove any dl()
>code, or come up with something, that will force the modules/ directory
>on the testkit.
>
>This is again a good reason to setup php.ini-test.
>Windows will then be a problem, which kinda makes the dl() thingy=
 troublesome
>as well.
>
>The only thing I can think of to work around it, is to use a configure
>option, that writes --with-test-modules-dir=3D into php.ini-test. But=
 that's
>prolly overkill.
>
>
>
>Met vriendelijke groeten / With kind regards,
>
>Webmaster IDG.nl
>Melvyn Sopacua
>

--=====================_71195359==_.ALT--